RTP: resume at access-unit boundary after packet loss, not NAL start

After a sequence gap the H.264/H.265 depacketizers resumed reassembly at
the next NAL/FU start. On multi-slice streams every slice starts a NAL,
so reassembly resumed MID-FRAME and delivered access units missing their
leading slices — manufacturing "First slice in a frame missing" /
"Ignoring POC change between slices" / "Could not find ref" decoder
errors and green/blocky concealment output far beyond the actual loss.

Resume only at a true AU boundary instead:
  H.265 - non-VCL NAL (type >= 32) or VCL slice with
          first_slice_segment_in_pic_flag set (first bit after the
          2-byte NAL header)
  H.264 - non-VCL NAL (type >= 6) or VCL slice with
          first_mb_in_slice == 0 (ue(v): MSB set after 1-byte header)

Also: stderr visibility for RTP sequence gaps (rtp_rx logs went only to
the sys_log file) and for av_log-bridge latches in video_decoder — the
global av_log level filters decoder errors from the console, which made
keyframe-gate arms look causeless during diagnosis.

Live verification, HEVC camera on lossy Wi-Fi (NVDEC decode):
  before: 271 decoder errors / 3 min, delivery collapsed to ~2 fps
  after:  3 errors / 2 min, full ~21 fps, zero corrupt frames displayed
Remaining rare errors show POC ref misses with ZERO RTP sequence gaps,
i.e. pre-decode queue eviction under TCP burst clumps - a separate,
much smaller issue absorbed invisibly by the keyframe gate.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
2026-07-07 06:09:37 +10:00
co-authored by Claude Fable 5
parent b341392e0f
commit 7909c8db2b
4 changed files with 78 additions and 23 deletions
+22 -7
View File
@@ -197,16 +197,31 @@ BOOL h264_data_rx(H264RXI * p_rxi, uint8 * p_data, int len)
if (p_rxi->rtprxi.rxf_loss)
{
// Packet loss, until the next start packet
if (!beginPacket)
// Packet loss — resume ONLY at an access-unit boundary (see the
// H.265 counterpart in h265_rtp_rx.cpp for the full rationale).
// Resuming at a mere NAL/FU start delivers frames missing their
// leading slices on multi-slice streams. An AU boundary is a
// non-VCL NAL (SEI/SPS/PPS/AUD, type >= 6) or a VCL slice whose
// first_mb_in_slice == 0 — ue(v)-coded, so value 0 is a single
// '1' bit: MSB of the byte after the 1-byte NAL header.
BOOL auStart = FALSE;
if (beginPacket)
{
uint8* payload = headerStart + numBytesToSkip;
int payloadLen = (int)packetSize - (int)numBytesToSkip;
if (payloadLen >= 2)
{
uint8 nt = payload[0] & 0x1F;
if (nt >= 6) auStart = TRUE; // non-VCL
else if (payload[1] & 0x80) auStart = TRUE; // first_mb_in_slice == 0
}
}
if (!auStart)
{
p_rxi->d_offset = 0;
return FALSE;
}
else
{
p_rxi->rtprxi.rxf_loss = 0;
}
p_rxi->rtprxi.rxf_loss = 0;
}
// save the H264 parameter sets
+26 -7
View File
@@ -265,16 +265,35 @@ BOOL h265_data_rx(H265RXI * p_rxi, uint8 * p_data, int len)
if (p_rxi->rtprxi.rxf_loss)
{
// Packet loss, until the next start packet
if (!beginPacket)
// Packet loss — resume ONLY at an access-unit boundary.
//
// The old behaviour resumed at the next NAL/FU start, but with
// multi-slice frames every slice starts a NAL, so reassembly resumed
// MID-FRAME and delivered access units missing their leading slices.
// The decoder then logs "First slice in a frame missing" / "Ignoring
// POC change between slices" and conceals the damage as green/blocky
// garbage. An AU boundary is either a non-VCL NAL (VPS/SPS/PPS/SEI,
// type >= 32, which precede an IDR) or a VCL slice with
// first_slice_segment_in_pic_flag set — the first bit after the
// 2-byte NAL header (H.265 spec 7.3.6.1).
BOOL auStart = FALSE;
if (beginPacket)
{
uint8* payload = headerStart + numBytesToSkip;
int payloadLen = (int)packetSize - (int)numBytesToSkip;
if (payloadLen >= 3)
{
uint8 nt = (payload[0] >> 1) & 0x3F;
if (nt >= 32) auStart = TRUE; // non-VCL (param sets/SEI)
else if (payload[2] & 0x80) auStart = TRUE; // first slice in picture
}
}
if (!auStart)
{
p_rxi->d_offset = 0;
return FALSE;
}
else
{
p_rxi->rtprxi.rxf_loss = 0;
}
p_rxi->rtprxi.rxf_loss = 0;
}
// save the H265 parameter sets
+7 -2
View File
@@ -105,8 +105,13 @@ BOOL rtp_data_rx(RTPRXI * p_rxi, uint8 * p_data, int len)
if (p_rxi->seq && p_rxi->seq != (uint16)(rtpSeq - 1))
{
p_rxi->rxf_loss = 1;
log_print(HT_LOG_WARN, "%s, prev seq[%u], cur seq[%u]!!!\r\n", __FUNCTION__, p_rxi->seq, rtpSeq);
}
log_print(HT_LOG_WARN, "%s, prev seq[%u], cur seq[%u]!!!\r\n", __FUNCTION__, p_rxi->seq, rtpSeq);
// stderr too (log_print goes to the log file): over TCP transport a
// sequence gap means the SENDER (camera) skipped packets — usually
// backpressure from a slow receiver. Gap size shows how much vanished.
fprintf(stderr, "[RTP] seq gap: prev=%u cur=%u (lost ~%u pkt)\n",
p_rxi->seq, rtpSeq, (uint16)(rtpSeq - p_rxi->seq - 1));
}
p_rxi->seq = rtpSeq;
p_rxi->rxf_marker = rtpMarkerBit;